-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(web-components): selected items with hover state are lined up correctly in nav group #3121
Merged
GCHQ-Developer-299
merged 2 commits into
v3.0.0/develop
from
2808-ic-navigation-item-selected-items-with-hover-state-arent-lined-up-properly-within-nav-group-menu
Feb 13, 2025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1a1be57
to
061a217
Compare
56651e1
to
963dcef
Compare
963dcef
to
87de32e
Compare
87de32e
to
5c80390
Compare
…rectly in nav group fix: selected items with hover state are properly lined up within nav group menu
621b242
to
714bf15
Compare
3a1e5a8
to
7e0ec5e
Compare
ad9242
approved these changes
Feb 10, 2025
GCHQ-Developer-299
requested changes
Feb 11, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm unsure what this PR is fixing - looking at the v3 develop branch this issue is already fixed - see screenshot below:
Is there somewhere else in storybook that I can see where this change has fixed the issue?
@GCHQ-Developer-299 - the issue occured on desktop: |
GCHQ-Developer-847
approved these changes
Feb 11, 2025
fa8f16c
to
8f687d3
Compare
GCHQ-Developer-299
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: selected items with hover state are properly lined up within nav group menu
Checklist
General
Testing
Accessibility
Resize/zoom behaviour
System modes
Testing content extremes